From 91c3a12fc9c676b299fe9109456bc086851c49d7 Mon Sep 17 00:00:00 2001
From: adrien <ponsinadrien@gmail.com>
Date: Mon, 18 Apr 2022 23:42:24 +0200
Subject: [PATCH] Update script using best practices

---
 .gitignore    |  1 +
 gitea-updater | 69 ++++++++++++++++++++++++---------------------------
 2 files changed, 34 insertions(+), 36 deletions(-)
 create mode 100644 .gitignore

diff --git a/.gitignore b/.gitignore
new file mode 100644
index 0000000..9f11b75
--- /dev/null
+++ b/.gitignore
@@ -0,0 +1 @@
+.idea/
diff --git a/gitea-updater b/gitea-updater
index ff1ce9b..ddadf76 100644
--- a/gitea-updater
+++ b/gitea-updater
@@ -1,65 +1,62 @@
 #! /usr/bin/env bash
 
-# all executed commands are printed to stdout
+# All executed commands are printed to stdout
 set -x
 
-# redirect stdout (and stderr to stdout) to a file
-exec 1> /var/log/updater/gitea-updater/gitea-$(date +%F).log 2>&1
+# Redirect stdout (and stderr to stdout) to a file
+exec 1>/var/log/updater/gitea-updater/gitea-"$(date +%F)".log 2>&1
 
-# abort on nonzero exitstatus
+# Abort on nonzero exit status
 set -o errexit
 
-# abort on unbound variable
+# Abort on unbound variable
 set -o nounset
 
-# don't hide errors within pipes
+# Don't hide errors within pipes
 set -o pipefail
 
-# set your API key here
+# Set your API key here
 key=
 
-# set your chat id here
+# Set your chat id here
 chat_id=
 
 function send_message() {
-	if [ $# -eq 0 ]
-	then
-		echo "No argument supplied. Please specify the message to send."
-	else
-		curl --silent --show-error --fail --request POST https://api.telegram.org/${key}/sendMessage --data chat_id=${chat_id} --data text="${1}" --output /dev/null
-	fi
+  if [ $# -eq 0 ]; then
+    echo "No argument supplied, please specify the message to send"
+  else
+    curl --silent --show-error --fail --request POST "https://api.telegram.org/$key/sendMessage" --data chat_id="$chat_id" --data text="$1" --output /dev/null
+  fi
 }
 
 function update_gitea() {
-	systemctl stop gitea.service
+  systemctl stop gitea.service
 
-	# download the latest version
-	curl --location --output /usr/local/bin/gitea --silent --show-error --fail https://dl.gitea.io/gitea/${1}/gitea-${1}-linux-amd64
+  # Download the latest version
+  curl --location --output /usr/local/bin/gitea --silent --show-error --fail --request GET "https://dl.gitea.io/gitea/$1/gitea-$1-linux-amd64"
 
-	# set the correct permissions
-	chmod +x /usr/local/bin/gitea
-	/usr/sbin/restorecon /usr/local/bin/gitea
-	/usr/sbin/restorecon /var/lib/gitea/log/gitea.log
+  # Set the correct permissions
+  /usr/bin/chmod +x /usr/local/bin/gitea
+  /usr/sbin/restorecon /usr/local/bin/gitea
+  /usr/sbin/restorecon /var/lib/gitea/log/gitea.log
 
-	if systemctl start gitea.service
-	then
-		send_message "[Gitea] - Gitea has just been updated."
-	else
-		send_message "[Gitea] - Gitea service did not start correctly. Please log in as soon as possible and see what went wrong."
-	fi
+  if systemctl start gitea.service; then
+    send_message "[Gitea] - Gitea has just been updated"
+  else
+    send_message "[Gitea] - Gitea service did not start correctly. Please log in as soon as possible and see what went wrong"
+  fi
 }
 
-# retrieve local release
+# Retrieve local release
 local_release=$(/usr/local/bin/gitea --version | awk '{print $3}')
 
-# retrieve the latest release
-latest_release=$(curl -sSf "https://api.github.com/repos/go-gitea/gitea/releases/latest" | grep '"tag_name":' | sed --regexp-extended 's/.*"([^"]+)".*/\1/' | cut --characters=2-)
+# Retrieve the latest release
+latest_release=$(curl --silent --show-error --fail --request GET "https://api.github.com/repos/go-gitea/gitea/releases/latest" | grep '"tag_name":' | sed --regexp-extended 's/.*"([^"]+)".*/\1/' | cut --characters=2-)
 
-# compare these two versions
-if [ ${latest_release} == ${local_release} ]
-then
-	send_message "[Gitea] - Gitea is up to date."
+# Compare these two versions
+if [ "$latest_release" == "$local_release" ]; then
+  send_message "[Gitea] - Gitea is up to date"
 else
-	send_message "[Gitea] - Gitea is not up to date (https://github.com/go-gitea/gitea/releases/tag/v${latest_release})."
-	update_gitea ${latest_release}
+  send_message "[Gitea] - Gitea is not up to date (https://github.com/go-gitea/gitea/releases/tag/v$latest_release)"
+  update_gitea "$latest_release"
 fi